From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
mikey@neuling.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/watchpoint: Don't call dar_within_range() for Book3S
Date: Thu, 27 Feb 2020 23:31:34 +1100 (AEDT) [thread overview]
Message-ID: <48SsVH2qCSz9sRY@ozlabs.org> (raw)
In-Reply-To: <20200222082049.330435-1-ravi.bangoria@linux.ibm.com>
On Sat, 2020-02-22 at 08:20:49 UTC, Ravi Bangoria wrote:
> DAR is set to the first byte of overlap between actual access and
> watched range at DSI on Book3S processor. But actual access range
> might or might not be within user asked range. So for Book3S, it
> must not call dar_within_range().
>
> This revert portion of commit 39413ae00967 ("powerpc/hw_breakpoints:
> Rewrite 8xx breakpoints to allow any address range size.").
>
> Before patch:
> # ./tools/testing/selftests/powerpc/ptrace/perf-hwbreak
> ...
> TESTED: No overlap
> FAILED: Partial overlap: 0 != 2
> TESTED: Partial overlap
> TESTED: No overlap
> FAILED: Full overlap: 0 != 2
> failure: perf_hwbreak
>
> After patch:
> TESTED: No overlap
> TESTED: Partial overlap
> TESTED: Partial overlap
> TESTED: No overlap
> TESTED: Full overlap
> success: perf_hwbreak
>
> Fixes: 39413ae00967 ("powerpc/hw_breakpoints: Rewrite 8xx breakpoints to allow any address range size.")
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/e08658a657f974590809290c62e889f0fd420200
cheers
prev parent reply other threads:[~2020-02-27 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 8:20 [PATCH] powerpc/watchpoint: Don't call dar_within_range() for Book3S Ravi Bangoria
2020-02-22 8:20 ` Ravi Bangoria
2020-02-22 11:26 ` Christophe Leroy
2020-02-22 13:16 ` Ravi Bangoria
2020-02-22 13:16 ` Ravi Bangoria
2020-02-27 12:31 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48SsVH2qCSz9sRY@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.