From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3 1/5] powerpc: Rename current_stack_pointer() to current_stack_frame()
Date: Fri, 6 Mar 2020 11:27:54 +1100 (AEDT) [thread overview]
Message-ID: <48YT3Z34Spz9sSm@ozlabs.org> (raw)
In-Reply-To: <20200220115141.2707-1-mpe@ellerman.id.au>
On Thu, 2020-02-20 at 11:51:37 UTC, Michael Ellerman wrote:
> current_stack_pointer(), which was called __get_SP(), used to just
> return the value in r1.
>
> But that caused problems in some cases, so it was turned into a
> function in commit bfe9a2cfe91a ("powerpc: Reimplement __get_SP() as a
> function not a define").
>
> Because it's a function in a separate compilation unit to all its
> callers, it has the effect of causing a stack frame to be created, and
> then returns the address of that frame. This is good in some cases
> like those described in the above commit, but in other cases it's
> overkill, we just need to know what stack page we're on.
>
> On some other arches current_stack_pointer is just a register global
> giving the stack pointer, and we'd like to do that too. So rename our
> current_stack_pointer() to current_stack_frame() to make that
> possible.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Series applied to powerpc next.
https://git.kernel.org/powerpc/c/3d13e839e801e081bdece0127c2affa33d0f77cf
cheers
prev parent reply other threads:[~2020-03-06 1:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 11:51 [PATCH v3 1/5] powerpc: Rename current_stack_pointer() to current_stack_frame() Michael Ellerman
2020-02-20 11:51 ` [PATCH v3 2/5] powerpc: Add current_stack_pointer as a register global Michael Ellerman
2020-02-20 11:51 ` [PATCH v3 3/5] powerpc/irq: Use current_stack_pointer in check_stack_overflow() Michael Ellerman
2020-02-20 11:51 ` [PATCH v3 4/5] powerpc/irq: use IS_ENABLED() " Michael Ellerman
2020-02-20 11:51 ` [PATCH v3 5/5] powerpc/irq: Use current_stack_pointer in do_IRQ() Michael Ellerman
2020-02-20 13:26 ` [PATCH v3 1/5] powerpc: Rename current_stack_pointer() to current_stack_frame() Christophe Leroy
2020-03-06 0:27 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48YT3Z34Spz9sSm@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.