From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [PATCH] examples/ipsec-secgw: Calling risky function
Date: Tue, 7 Jun 2016 09:15:28 +0100
Message-ID: <48bb7dd9-a8cb-167a-ce7c-868427be578b@intel.com>
References: <1465289886-14479-1-git-send-email-slawomirx.mrozowicz@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id EE7E095CE
 for <dev@dpdk.org>; Tue,  7 Jun 2016 10:15:30 +0200 (CEST)
In-Reply-To: <1465289886-14479-1-git-send-email-slawomirx.mrozowicz@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 07/06/2016 09:58, Slawomir Mrozowicz wrote:
> lrand48 should not be used for security related applications,
> as linear congruential algorithms are too easy to break.
> Used a compliant random number generator /dev/urandom.
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> Coverity ID 124558
>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> ---

I understand that lrand48 is not crypto secure, but this fix will kill 
performance.

I already have a solution for this issue to be included in the next 
IPSec patch set
that will also add support for GCM/CTR modes.

Sergio