All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Hartge <sven@svenhartge.de>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] via-velocity: earlier name allocation
Date: Thu, 23 Oct 2008 09:29:34 +0200	[thread overview]
Message-ID: <490027DE.3000409@svenhartge.de> (raw)
In-Reply-To: <20081022170422.7851ea9a@extreme>

Stephen Hemminger wrote:


> NAK
> 
> There is nothing to prevent that device name from being allocated by another device
> at that point.  The correct fix is to not use dev->name until after registering
> the network device.  Change the order of registration or pass dev_driver_string(&pdev->dev)
> instead of dev->name to velocity_get_options

Fine with me. This was just the hint I was looking for. If you don't
mind, I will mail a new patch for this case later.

S°


  reply	other threads:[~2008-10-23  7:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 23:24 [PATCH] via-velocity: earlier name allocation Sven Hartge
2008-10-23  0:04 ` Stephen Hemminger
2008-10-23  7:29   ` Sven Hartge [this message]
2008-10-23 23:03   ` [PATCH v2] via-velocity: use driver string instead of dev->name before register_netdev() Sven Hartge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490027DE.3000409@svenhartge.de \
    --to=sven@svenhartge.de \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.