All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix _mimagetmp left activated after upconversion of inactive mirrored LV
Date: Thu, 23 Oct 2008 09:45:52 +0200	[thread overview]
Message-ID: <49002BB0.3060603@redhat.com> (raw)
In-Reply-To: <490020E8.4000401@ce.jp.nec.com>

Jun'ichi Nomura wrote:
>> commit e36b529d7381725e839befcf001e9453eda6886a
>> Author: Alasdair Kergon <agk@redhat.com>
>> Date:   Fri Oct 17 10:57:14 2008 +0000
>>
>>     Use temp table to set device size when converting mirrors.
>>     
>>     (Avoids having same mirror table loaded twice concurrently by first
>>     using a 'zero' table to set the size of the device so when mirror
>>     table is preloaded it doesn't have to be activated immediately.)
> 
> This change broke t-mirror-vgreduce-removemissing.sh test.

Hi,

yes, it broke tests and not only this test. There is already patch,
but unfortunately not yet in CVS/git...

This commit also introduced using zero target, which is not guaranteed
to be properly initialized there (try to run without dm_zero loaded),
so new patch also uses error target instead for temporary mapping.


Thanks,
Milan



      reply	other threads:[~2008-10-23  7:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23  6:59 [PATCH] Fix _mimagetmp left activated after upconversion of inactive mirrored LV Jun'ichi Nomura
2008-10-23  7:45 ` Milan Broz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49002BB0.3060603@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.