From: Benjamin Thery <benjamin.thery@bull.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: netdev <netdev@vger.kernel.org>,
Dave Miller <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Al Viro <viro@ftp.linux.org.uk>, Serge Hallyn <serue@us.ibm.com>,
Daniel Lezcano <dlezcano@fr.ibm.com>,
linux-kernel@vger.kernel.org, Tejun Heo <htejun@gmail.com>,
Denis Lunev <den@openvz.org>,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device sysfs entries
Date: Thu, 23 Oct 2008 13:56:33 +0200 [thread overview]
Message-ID: <49006671.3010804@bull.net> (raw)
In-Reply-To: <m1d4hso0ym.fsf@frodo.ebiederm.org>
Eric W. Biederman wrote:
> Benjamin Thery <benjamin.thery@bull.net> writes:
>
>> Support for network namespaces in mainline is pretty complete for
>> some time now, but there is still this issue with sysfs that prevents
>> more people to use it easily.
>
> Ben your patchset is completely inappropriate.
>
> Temporarily adding elements to the ABI that we intend to remove
> is not a proper solution to this problem.
In fact, I feared that would be an issue before I sent the patches.
Thanks for confirming this.
But, as this alternative was discussed a bit after Al's comments on your
last patches, I had to give it a try and code a proof-of-concept.
Benjamin
>
> That user space visible ida you add is a namespace identifier that breaks
> nested containers and migration. It is very very very wrong.
>
> Eric
>
>
>
--
B e n j a m i n T h e r y - BULL/DT/Open Software R&D
http://www.bull.com
next prev parent reply other threads:[~2008-10-23 12:00 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 15:21 [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device sysfs entries Benjamin Thery
2008-10-22 15:21 ` [PATCH 1/4] netns: add in ida ID to identify the network namespace Benjamin Thery
2008-10-22 15:21 ` Benjamin Thery
2008-10-22 15:22 ` [PATCH 2/4] netns: Export nets id to /proc/net/netns Benjamin Thery
2008-10-22 15:22 ` Benjamin Thery
2008-10-22 15:22 ` [PATCH 3/4] net: cleanup some vars names to be more consistant with the network code Benjamin Thery
2008-10-22 15:22 ` Benjamin Thery
2008-10-22 15:22 ` [PATCH 4/4] netns: sysfs: add netns suffix to net devices sysfs entries Benjamin Thery
2008-10-22 15:22 ` Benjamin Thery
2008-10-22 19:59 ` [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device " Eric W. Biederman
2008-10-22 20:30 ` Serge E. Hallyn
[not found] ` <20081022203045.GA4633-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-10-22 21:01 ` Eric W. Biederman
2008-10-22 21:01 ` Eric W. Biederman
2008-10-22 21:55 ` Stephen Hemminger
2008-10-22 22:54 ` Eric W. Biederman
2008-10-22 22:54 ` Eric W. Biederman
2008-10-23 4:14 ` Kyle Moffett
[not found] ` <m11vy8jl5s.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-23 4:14 ` Kyle Moffett
[not found] ` <m18wsgmji0.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-22 21:55 ` Stephen Hemminger
2008-10-23 11:56 ` Benjamin Thery [this message]
2008-10-23 15:46 ` Eric W. Biederman
[not found] ` <49006671.3010804-6ktuUTfB/bM@public.gmane.org>
2008-10-23 15:46 ` Eric W. Biederman
[not found] ` <m1d4hso0ym.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-22 20:30 ` Serge E. Hallyn
2008-10-23 11:56 ` Benjamin Thery
2008-10-22 20:16 ` Greg KH
[not found] ` <20081022201601.GC24959-l3A5Bk7waGM@public.gmane.org>
2008-10-22 21:08 ` Eric W. Biederman
2008-10-22 21:08 ` Eric W. Biederman
[not found] ` <m17i80l4mt.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-22 21:24 ` Greg KH
2008-10-22 21:24 ` Greg KH
[not found] ` <20081022152144.351965414-4vkkeT0zb4ZEtYaxpPmRp1aPQRlvutdw@public.gmane.org>
2008-10-22 19:59 ` Eric W. Biederman
2008-10-22 20:16 ` Greg KH
2008-10-22 20:32 ` [PATCH] netns: Coexist with the sysfs limitations Eric W. Biederman
2008-10-22 20:32 ` Eric W. Biederman
2008-10-22 20:40 ` Daniel Lezcano
[not found] ` <m17i80nzff.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-22 20:40 ` Daniel Lezcano
2008-10-22 21:21 ` Serge E. Hallyn
2008-10-22 21:21 ` Serge E. Hallyn
[not found] ` <20081022212124.GA9910-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-10-23 8:04 ` Benjamin Thery
2008-10-23 8:04 ` Benjamin Thery
2008-10-23 15:40 ` Eric W. Biederman
[not found] ` <49003019.40904-6ktuUTfB/bM@public.gmane.org>
2008-10-23 15:40 ` Eric W. Biederman
2008-10-23 15:56 ` [PATCH] netns: Coexist with the sysfs limitations v2 Eric W. Biederman
2008-10-23 15:56 ` Eric W. Biederman
[not found] ` <m1fxmni9uv.fsf_-_-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-27 19:41 ` David Miller
2008-10-27 19:41 ` David Miller
[not found] ` <20081027.124126.74749150.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-10-27 20:19 ` Eric W. Biederman
2008-10-27 20:19 ` Eric W. Biederman
[not found] ` <m1skqh4wq8.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-10-28 0:50 ` David Miller
2008-10-28 0:50 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-10-22 15:21 [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device sysfs entries Benjamin Thery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49006671.3010804@bull.net \
--to=benjamin.thery@bull.net \
--cc=containers@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.