From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] eal: fix parsing zero socket memory and limits Date: Wed, 23 Jan 2019 23:03:07 +0100 Message-ID: <4900677.582JXVQWH1@xps> References: <20190122162714.9144-1-i.maximets@samsung.com> <1a3eea71-1b1a-7589-48fa-71a23ee1e0a2@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, "Burakov, Anatoly" , dev@dpdk.org To: Ilya Maximets Return-path: In-Reply-To: <1a3eea71-1b1a-7589-48fa-71a23ee1e0a2@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/01/2019 11:15, Burakov, Anatoly: > On 22-Jan-19 4:27 PM, Ilya Maximets wrote: > > Modern memory mode allowes to not reserve any memory by the > > '--socket-mem' option. i.e. it could be possible to specify > > zero preallocated memory like '--socket-mem 0'. > > Also, it should be possible to configure unlimited memory > > allocations by '--socket-limit 0'. > > > > Both cases are impossible now and blocks starting the DPDK > > application: > > > > ./dpdk-app --socket-limit 0 <...> > > EAL: invalid parameters for --socket-limit > > EAL: Invalid 'command line' arguments. > > Unable to initialize DPDK: Invalid argument > > > > Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ilya Maximets > > --- > > That's kind of an odd parameter to pass, as it is assumed that if you > don't need any limitations or preallocated memory, you don't specify > these flags in the first place, but OK :) > > Acked-by: Anatoly Burakov Applied, thanks