From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0/8] Support for S3 ACPI state (suspend to memory) Date: Thu, 23 Oct 2008 13:17:31 -0500 Message-ID: <4900BFBB.6070300@codemonkey.ws> References: <20081023140459.10303.39562.stgit@gleb-debian.qumranet.com.qumranet.com> <4900A28B.6050509@codemonkey.ws> <4900A879.3030505@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from el-out-1112.google.com ([209.85.162.183]:2126 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757954AbYJWSRk (ORCPT ); Thu, 23 Oct 2008 14:17:40 -0400 Received: by el-out-1112.google.com with SMTP id z25so189261ele.1 for ; Thu, 23 Oct 2008 11:17:34 -0700 (PDT) In-Reply-To: <4900A879.3030505@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Anthony Liguori wrote: >> >> I thought you initially sent this to qemu-devel. Any reason not to >> push this through QEMU instead of in KVM? >> > > Since it requires bios changes, it is basically unpushable to qemu. Why? As long as Gleb is willing to push those changes to Bochs, I'll stick them in the bios.diff for now. The hard part is the dsdt changes but if the build is changed to run the dsdt through cpp first, we can just #ifdef BX_QEMU the qemu specific stuff. > It may also depend on existing kvm bios and acpi changes. How much dependency is there here? > > If it is possible to do this via qemu, of course I much prefer that > route. I looked through the patches. They're quite reasonable so I'd like to push them into QEMU if it's possible. Regards, Anthony Liguori