From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: pass netns to ->match or to not pass
Date: Fri, 24 Oct 2008 05:43:04 +0200 [thread overview]
Message-ID: <49014448.4090405@trash.net> (raw)
In-Reply-To: <20081023231611.GA19245@x200.localdomain>
Alexey Dobriyan wrote:
> xt_recent wants netns inside ->match hook (and xt_hashlimit probably,
> haven't looked closely):
>
> recent_mt
> recent_table_lookup
> [use per-netns tables list]
>
> Now, I can drag netns through struct xt_match_param, or use
> dev_net(skb->dev ? skb->dev : skb->dst->dev) trick.
>
> And the latter should be better, because only xt_recent module will be
> affected.
>
> Comments?
I prefer the later. Using the supplied device parameters would
be better though to keep the device handling centralized.
prev parent reply other threads:[~2008-10-24 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 23:16 pass netns to ->match or to not pass Alexey Dobriyan
2008-10-23 23:17 ` Jan Engelhardt
2008-10-23 23:36 ` Alexey Dobriyan
2008-10-24 0:23 ` Jan Engelhardt
2008-10-24 9:45 ` Alexey Dobriyan
2008-10-24 13:31 ` Jan Engelhardt
2008-10-24 14:10 ` Alexey Dobriyan
2008-10-24 15:06 ` Jan Engelhardt
2008-10-24 16:25 ` Alexey Dobriyan
2008-10-24 3:43 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49014448.4090405@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.