From: Thomas Monjalon <thomas@monjalon.net>
To: Rui Ferreira <rui.ferreira1@h-partners.com>
Cc: stable@dpdk.org, dev@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 2/2] fix eal/freebsd: unregister alarm callback before free
Date: Mon, 09 Jun 2025 14:45:23 +0200 [thread overview]
Message-ID: <4901987.Y6S9NjorxK@thomas> (raw)
In-Reply-To: <aD6yTxLUgI3jxlPe@bricha3-mobl1.ger.corp.intel.com>
03/06/2025 10:29, Bruce Richardson:
> On Fri, May 30, 2025 at 09:18:44AM +0100, Rui Ferreira wrote:
> > Unregister callback on cleanup to avoid use after free from the
> > interrupt thread (eal_intr_thread_main).
> >
> > To be more defensive, set ptr to NULL if we can unregister.
> >
> > rte_intr_callback_unregister_sync may (optionally) use traces
> > so the alarm cleanup must happen before eal_trace_fini to avoid
> > accessing freed memory.
> >
> > Bugzilla ID: 1683
>
> Source of bug is probably:
>
> Fixes: 90b13ab8d4f7 ("alarm: remove direct access to interrupt handle")
>
> >
> > Signed-off-by: Rui Ferreira <rui.ferreira1@h-partners.com>
>
> Patch looks ok to me.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
I think we should keep trace saving just before trace closing.
Applied with this change, thanks.
prev parent reply other threads:[~2025-06-09 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 16:01 [PATCH] eal/linux: unregister alarm callback before free ptr Rui Ferreira
2025-05-21 8:49 ` David Marchand
2025-05-21 11:43 ` Konstantin Ananyev
2025-05-22 15:59 ` [PATCH v2] fix eal/linux: unregister alarm callback before free Rui Ferreira
2025-05-27 10:22 ` Konstantin Ananyev
2025-05-27 14:53 ` Thomas Monjalon
2025-05-29 8:39 ` Rui Ferreira (A)
2025-05-30 8:18 ` [PATCH v2 0/2] fix eal: " Rui Ferreira
2025-05-30 8:18 ` [PATCH v2 1/2] fix eal/linux: " Rui Ferreira
2025-05-30 8:18 ` [PATCH v2 2/2] fix eal/freebsd: " Rui Ferreira
2025-06-03 8:29 ` Bruce Richardson
2025-06-09 12:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4901987.Y6S9NjorxK@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rui.ferreira1@h-partners.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.