From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
linux-mips@linux-mips.org, linux-ide@vger.kernel.org,
ralf@linux-mips.org
Subject: Re: [PATCH] ide: Add tx4938ide driver (v2)
Date: Fri, 24 Oct 2008 15:12:15 +0400 [thread overview]
Message-ID: <4901AD8F.4000007@ru.mvista.com> (raw)
In-Reply-To: <200810232247.05686.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
>> This is the driver for the Toshiba TX4938 SoC EBUS controller ATA mode.
>> It has custom set_pio_mode and some hacks for big endian.
>>
>> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>>
>
> I applied it so please address issues left (if any) with incremental patches.
>
I'm not sure there was really a need to haste it into -rc1 (if you
could push it to Linus later anyway)...
I've realized that I have a question to Atsushi on why he chose the
same way of implemnting the register accesses as on TX4939 despite
TX4938 IDE is not really a SoC but a board level device (so probable
should be using the normal, not the "raw" I/O accessors)...
MBR, Sergei
next prev parent reply other threads:[~2008-10-24 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 16:20 [PATCH] ide: Add tx4938ide driver (v2) Atsushi Nemoto
2008-10-23 17:38 ` Sergei Shtylyov
2008-10-24 15:55 ` Atsushi Nemoto
2008-10-24 16:06 ` Atsushi Nemoto
2008-10-23 20:47 ` Bartlomiej Zolnierkiewicz
2008-10-24 11:12 ` Sergei Shtylyov [this message]
2008-10-24 14:20 ` Atsushi Nemoto
2009-02-08 11:44 ` Sergei Shtylyov
2009-02-08 11:52 ` Sergei Shtylyov
2009-02-08 16:53 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4901AD8F.4000007@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.