From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KtNbt-0002Tk-Mk for qemu-devel@nongnu.org; Fri, 24 Oct 2008 10:25:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KtNbr-0002Rx-Ji for qemu-devel@nongnu.org; Fri, 24 Oct 2008 10:25:52 -0400 Received: from [199.232.76.173] (port=60034 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KtNbr-0002Rq-Eq for qemu-devel@nongnu.org; Fri, 24 Oct 2008 10:25:51 -0400 Received: from rn-out-0910.google.com ([64.233.170.191]:55314) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KtNbr-0003vk-A2 for qemu-devel@nongnu.org; Fri, 24 Oct 2008 10:25:51 -0400 Received: by rn-out-0910.google.com with SMTP id m61so602943rnd.8 for ; Fri, 24 Oct 2008 07:25:48 -0700 (PDT) Message-ID: <4901DAE8.6080905@codemonkey.ws> Date: Fri, 24 Oct 2008 09:25:44 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [5524] Fix windows build after migration changes References: <4901D92C.8070800@bttr-software.de> In-Reply-To: <4901D92C.8070800@bttr-software.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Robert Riebisch wrote: > Anthony Liguori wrote: > > >> The live migration code broke the windows build. As part of this >> change, I've switched the BIOS path to C:\Program Files\Qemu instead of >> /c/Program Files/Qemu. The later is only valid when launching from MSYS >> but the former is always valid. >> > > Why do you always want the BIOS path hard-coded? I've made a small patch > for QEMU 0.9.1 to determine path, i.e. current directory, at runtime. I > could send it to you for adapting to SVN. > That would be great. I don't know that we want to go on the current directory though. There's a Windows API for finding Program Files. That's probably what we want to do. Regards, Anthony Liguori > Robert Riebisch >