From: Mike Ditto <mditto@consentry.com>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc: Add missing irq free in fs_enet error path.
Date: Fri, 24 Oct 2008 16:10:18 -0700 [thread overview]
Message-ID: <490255DA.40104@consentry.com> (raw)
If something goes wrong attaching to phy driver, we weren't freeing the IRQ.
Signed-off-by: Mike Ditto <mditto@consentry.com>
---
cvs diff -r linux-2_6_27 -upN linux/drivers/net/fs_enet/fs_enet-main.c
Index: linux/drivers/net/fs_enet/fs_enet-main.c
===================================================================
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 fs_enet-main.c
--- linux/drivers/net/fs_enet/fs_enet-main.c 11 Oct 2008 02:53:59 -0000 1.1.1.1
+++ linux/drivers/net/fs_enet/fs_enet-main.c 24 Oct 2008 22:19:47 -0000
@@ -811,6 +811,7 @@ static int fs_enet_open(struct net_devic
err = fs_init_phy(dev);
if (err) {
+ fs_free_irq(dev, fep->interrupt);
if (fep->fpi->use_napi)
napi_disable(&fep->napi);
return err;
reply other threads:[~2008-10-24 23:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490255DA.40104@consentry.com \
--to=mditto@consentry.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.