All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Ditto <mditto@consentry.com>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH v2] powerpc: Add missing irq free in fs_enet error path.
Date: Fri, 24 Oct 2008 18:03:00 -0700	[thread overview]
Message-ID: <49027044.90509@consentry.com> (raw)

If something goes wrong attaching to phy driver, we weren't freeing the IRQ.

Signed-off-by: Mike Ditto <mditto@consentry.com>
---
I just noticed this file has already been touched in -rc1 so here is the
patch again, adjusted accordingly.

diff -r -upN 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c NEW/drivers/net/fs_enet/fs_enet-main.c
--- 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c       2008-10-24 17:54:31.000000000 -0700
+++ NEW/drivers/net/fs_enet/fs_enet-main.c      2008-10-24 17:57:03.000000000 -0700
@@ -795,6 +795,7 @@ static int fs_enet_open(struct net_devic

        err = fs_init_phy(dev);
        if (err) {
+               free_irq(fep->interrupt, dev);
                if (fep->fpi->use_napi)
                        napi_disable(&fep->napi);
                return err;

             reply	other threads:[~2008-10-25  1:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-25  1:03 Mike Ditto [this message]
2008-10-27 13:45 ` [PATCH v2] powerpc: Add missing irq free in fs_enet error path Kumar Gala
2008-10-27 21:46   ` [PATCH v2] powerpc/fs_enet: Add missing irq free in " Mike Ditto
2009-01-13 16:28     ` Kumar Gala
2009-01-13 16:28       ` Kumar Gala
2009-01-15  4:44       ` David Miller
2009-01-15  4:44         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49027044.90509@consentry.com \
    --to=mditto@consentry.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.