From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
Bruce Allan <bruce.w.allan@intel.com>
Subject: Re: [PATCH] [PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk
Date: Fri, 24 Oct 2008 22:22:54 -0400 [thread overview]
Message-ID: <490282FE.9040602@garzik.org> (raw)
In-Reply-To: <9929d2390810241827o4b0f525dt1e34b4f17ddad4a6@mail.gmail.com>
Jeff Kirsher wrote:
> On Fri, Oct 24, 2008 at 6:13 PM, Jeff Kirsher
> <jeffrey.t.kirsher@intel.com> wrote:
>> From: Bruce Allan <bruce.w.allan@intel.com>
>>
>> The write-protection method being in the driver probe routine is called
>> late in the boot sequence, and not at all if the driver is never loaded.
>> By making it a PCI quirk the NVM is protected much earlier whether or not
>> the driver is loaded. The write-protection quirk can be disabled with a
>> new kernel parameter in the unlikely event the NVM needs to be modified.
>>
>> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> ---
>>
>> Documentation/kernel-parameters.txt | 4 +
>> drivers/net/Makefile | 1
>> drivers/net/e1000e/Makefile | 1
>> drivers/net/e1000e/e1000.h | 1
>> drivers/net/e1000e/ethtool.c | 6 +
>> drivers/net/e1000e/ich8lan.c | 93 +++-----------------
>> drivers/net/e1000e/ich8lan.h | 68 +++++++++++++++
>> drivers/net/e1000e/netdev.c | 4 -
>> drivers/net/e1000e/param.c | 30 ------
>> drivers/net/e1000e/quirks.c | 162 +++++++++++++++++++++++++++++++++++
>> 10 files changed, 256 insertions(+), 114 deletions(-)
>> create mode 100644 drivers/net/e1000e/ich8lan.h
>> create mode 100644 drivers/net/e1000e/quirks.c
>>
>>
>
> This PCI quirk is put in ./drivers/net/e1000e in order to share
> defines and structs found in the driver source, and is only applicable
> to ICHx GbE LOMs supported by that driver anyway.
Seems to be it is not difficult to put it into drivers/pci/quirks.c,
where it belongs.
Jeff
next prev parent reply other threads:[~2008-10-25 2:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 1:13 [PATCH] [PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk Jeff Kirsher
2008-10-25 1:27 ` Jeff Kirsher
2008-10-25 2:22 ` Jeff Garzik [this message]
2008-10-27 20:26 ` Allan, Bruce W
2008-10-30 16:16 ` Jesse Barnes
2008-10-30 18:29 ` Allan, Bruce W
2008-10-30 18:35 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490282FE.9040602@garzik.org \
--to=jeff@garzik.org \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.