All of lore.kernel.org
 help / color / mirror / Atom feed
From: walt <w41ter@gmail.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: commit a802dd0e breaks console keyboard input
Date: Sat, 25 Oct 2008 13:36:53 -0700	[thread overview]
Message-ID: <49038365.4070001@gmail.com> (raw)
In-Reply-To: <20081025141622.GA4397@osiris.boeblingen.de.ibm.com>

Heiko Carstens wrote:
> On Fri, Oct 24, 2008 at 04:13:59PM -0700, walt wrote:
>>> Please try the patch below. It basically reverts the whole stop_machine
>>> patches. That way we should know if it really comes from the moved init
>>> call or if it is some other weird bug. I would have expected more bug
>>> reports if the stop_machine patches would be broken. Hmmm...
>> <second patch snipped for brevity>
>>
>> Yes your second patch fixes the keyboard problem, thanks.  The lack of
>> other complainers is what made me think of a BIOS bug, but that's just
>> wild guesswork on my part.  I'm happy to keep trying patches if you can
>> keep making them :-)
>
> Thanks a lot for testing and your patience!
> The patch below moves the init call to its old place but makes the
> stop_machine initialization happen later. I added a BUG_ON to catch possible
> early calls, but there shouldn't be any. I think the patch should solve
> the regression you are seeing. Could you give it a try please?
> The patch applies on top of latest Linus' git tree...

<patch snipped for brevity>
Yes, everything seems back to normal with this patch, thanks.


      parent reply	other threads:[~2008-10-25 20:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24  0:09 commit a802dd0e breaks console keyboard input walt
2008-10-24  7:28 ` Heiko Carstens
2008-10-24 11:07 ` Heiko Carstens
2008-10-24 12:52   ` w41ter
2008-10-24 19:44     ` Heiko Carstens
2008-10-24 23:13       ` walt
2008-10-25 14:16         ` Heiko Carstens
2008-10-25 18:48           ` Hugh Dickins
2008-10-25 20:36           ` walt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49038365.4070001@gmail.com \
    --to=w41ter@gmail.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.