All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] lcd: Let the board code show board-specific info
Date: Sun, 26 Oct 2008 00:23:17 +0200	[thread overview]
Message-ID: <49039C55.2050102@denx.de> (raw)
In-Reply-To: <1220278882-26029-5-git-send-email-haavard.skinnemoen@atmel.com>

Haavard Skinnemoen wrote:
> The information displayed when CONFIG_LCD_INFO is set is inherently
> board-specific, so it should be done by the board code. The current code
> dealing with this only handles two cases, and is already a horrible mess
> of #ifdeffery.
> 
> Yes, this duplicates some code, but it also allows boards to print more
> board-specific information; this used to be very difficult.
> 
> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
> ---
>  board/atmel/at91cap9adk/at91cap9adk.c     |   29 ++++++++++
>  board/atmel/at91sam9261ek/at91sam9261ek.c |   29 ++++++++++
>  board/atmel/at91sam9263ek/at91sam9263ek.c |   29 ++++++++++
>  board/atmel/at91sam9rlek/at91sam9rlek.c   |   29 ++++++++++
>  board/lwmon/lwmon.c                       |   29 ++++++++++
>  board/tqc/tqm8xx/tqm8xx.c                 |   26 +++++++++
>  common/lcd.c                              |   84 ++---------------------------
>  include/lcd.h                             |    2 +
>  8 files changed, 178 insertions(+), 79 deletions(-)

Jean-Christophe, you ACKed this patch in
http://lists.denx.de/pipermail/u-boot/2008-October/042389.html.

Should it go through u-boot-video repository or do you intend to
pick it up?

Note that it needs some fixes:
s/CFG_MAX_NAND_DEVICE/CONFIG_SYS_MAX_NAND_DEVICE

Best regards,
Anatolij

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

  reply	other threads:[~2008-10-25 22:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 14:21 [U-Boot] [PATCH 1/5] atmel_lcdfb: Eliminate unneeded #include <asm/arch/hardware.h> Haavard Skinnemoen
2008-09-01 14:21 ` [U-Boot] [PATCH 2/5] atmel_lcdfb: Straighten out funky vl_sync logic Haavard Skinnemoen
2008-09-01 14:21   ` [U-Boot] [PATCH 3/5] lcd: Implement lcd_printf() Haavard Skinnemoen
2008-09-01 14:21     ` [U-Boot] [PATCH 4/5] lcd: Set lcd_is_enabled before clearing the screen Haavard Skinnemoen
2008-09-01 14:21       ` [U-Boot] [PATCH 5/5] lcd: Let the board code show board-specific info Haavard Skinnemoen
2008-10-25 22:23         ` Anatolij Gustschin [this message]
2008-10-26 11:56           ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-27  9:19         ` Anatolij Gustschin
2008-10-25 21:47       ` [U-Boot] [PATCH 4/5] lcd: Set lcd_is_enabled before clearing the screen Anatolij Gustschin
2008-10-25 21:45     ` [U-Boot] [PATCH 3/5] lcd: Implement lcd_printf() Anatolij Gustschin
2008-10-27 23:03       ` Wolfgang Denk
2008-09-02 11:44   ` [U-Boot] [PATCH 2/5] atmel_lcdfb: Straighten out funky vl_sync logic Detlev Zundel
2008-09-02 11:53     ` Haavard Skinnemoen
2008-10-25 21:33   ` Anatolij Gustschin
2008-10-25 21:26 ` [U-Boot] [PATCH 1/5] atmel_lcdfb: Eliminate unneeded #include <asm/arch/hardware.h> Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49039C55.2050102@denx.de \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.