From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/6] KVM/userspace: Device Assignment: Add ioctl wrappers needed for assigning devices Date: Sun, 26 Oct 2008 15:29:19 +0200 Message-ID: <490470AF.8070207@redhat.com> References: <1224861988-22781-1-git-send-email-amit.shah@redhat.com> <1224861988-22781-2-git-send-email-amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, anthony@codemonkey.ws, weidong.han@intel.com, allen.m.kay@intel.com, muli@il.ibm.com, benami@il.ibm.com To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56299 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753387AbYJZNaf (ORCPT ); Sun, 26 Oct 2008 09:30:35 -0400 In-Reply-To: <1224861988-22781-2-git-send-email-amit.shah@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > > +#ifdef KVM_CAP_DEVICE_ASSIGNMENT > +int kvm_assign_pci_device(kvm_context_t kvm, > + struct kvm_assigned_pci_dev *assigned_dev) > +{ > + return ioctl(kvm->vm_fd, KVM_ASSIGN_PCI_DEVICE, assigned_dev); > Convert -1s to -errno, to avoid problems with errno being overwritten later. > +} > + > +int kvm_assign_irq(kvm_context_t kvm, > + struct kvm_assigned_irq *assigned_irq) > +{ > + return ioctl(kvm->vm_fd, KVM_ASSIGN_IRQ, assigned_irq); > +} > +#endif > -- error compiling committee.c: too many arguments to function