From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/2] kvmtrace: Allow user to clean up stale trace setup Date: Sun, 26 Oct 2008 16:15:15 +0200 Message-ID: <49047B73.9000900@redhat.com> References: <1224696928-22187-1-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Eduardo Habkost Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55172 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752354AbYJZOPT (ORCPT ); Sun, 26 Oct 2008 10:15:19 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9QEFJ2E026577 for ; Sun, 26 Oct 2008 10:15:19 -0400 In-Reply-To: <1224696928-22187-1-git-send-email-ehabkost@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Eduardo Habkost wrote: > If kvmtrace crashes or gets killed while collecting trace data, stale > trace setup information may be enabled on the kernel, and currently > there is no way to force the previous trace setup to be overwritten > or disabled. > > The following two patches against kvm-userspace will add a new > command-line option to kvmtrace (-f), that will allow the user to forcibly > clean up an existing trace setup before enabling trace. > The long term plan is to drop kvmtrace in favor of the more generic frameworks (which provide a common trace transport, IIRC). Can you check if this has been merged (or if enough of it is in mainline)? This is exactly the sort of issues that are best handled by a generic implementation. -- error compiling committee.c: too many arguments to function