From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 05 Jul 2016 10:09:42 +0200 Subject: [PATCH 4/6] irqchip: add irqchip driver for nuc900 In-Reply-To: <577B660D.50908@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <8706947.5rzUDVsB2F@wuerfel> <577B660D.50908@iommu.org> Message-ID: <4905263.SDvl9l5FN0@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday, July 5, 2016 3:47:25 PM CEST Wan Zongshun wrote: > On 2016?06?29? 23:27, Arnd Bergmann wrote: > > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: > >> +#define IRQ_WDT W90X900_IRQ(1) > >> +#define IRQ_WWDT W90X900_IRQ(2) > >> +#define IRQ_LVD W90X900_IRQ(3) > >> +#define IRQ_EXT0 W90X900_IRQ(4) > >> +#define IRQ_EXT1 W90X900_IRQ(5) > >> +#define IRQ_EXT2 W90X900_IRQ(6) > >> +#define IRQ_EXT3 W90X900_IRQ(7) > >> +#define IRQ_EXT4 W90X900_IRQ(8) > >> +#define IRQ_EXT5 W90X900_IRQ(9) > >> +#define IRQ_EXT6 W90X900_IRQ(10) > > > > I'd suggest dropping the list, the contents are now in the dts. > > Do you think I should put one irqmap header file into this > /arch/arm/boot/dts/include/dt-bindings folder, or I should removed those > irqnumber map anywhere, just hardcode the irqnumber in dts file? Just hardcode it. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Date: Tue, 05 Jul 2016 10:09:42 +0200 Message-ID: <4905263.SDvl9l5FN0@wuerfel> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <8706947.5rzUDVsB2F@wuerfel> <577B660D.50908@iommu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <577B660D.50908-6ukY98dZOFrYtjvyW6yDsg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wan Zongshun Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wan Zongshun , Daniel Lezcano , Russell King , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner List-Id: devicetree@vger.kernel.org On Tuesday, July 5, 2016 3:47:25 PM CEST Wan Zongshun wrote: > On 2016=E5=B9=B406=E6=9C=8829=E6=97=A5 23:27, Arnd Bergmann wrote: > > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: > >> +#define IRQ_WDT W90X900_IRQ(1) > >> +#define IRQ_WWDT W90X900_IRQ(2) > >> +#define IRQ_LVD W90X900_IRQ(3) > >> +#define IRQ_EXT0 W90X900_IRQ(4) > >> +#define IRQ_EXT1 W90X900_IRQ(5) > >> +#define IRQ_EXT2 W90X900_IRQ(6) > >> +#define IRQ_EXT3 W90X900_IRQ(7) > >> +#define IRQ_EXT4 W90X900_IRQ(8) > >> +#define IRQ_EXT5 W90X900_IRQ(9) > >> +#define IRQ_EXT6 W90X900_IRQ(10) > > > > I'd suggest dropping the list, the contents are now in the dts. >=20 > Do you think I should put one irqmap header file into this > /arch/arm/boot/dts/include/dt-bindings folder, or I should removed th= ose=20 > irqnumber map anywhere, just hardcode the irqnumber in dts file? Just hardcode it. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754771AbcGEIHZ (ORCPT ); Tue, 5 Jul 2016 04:07:25 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:58385 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754641AbcGEIHW convert rfc822-to-8bit (ORCPT ); Tue, 5 Jul 2016 04:07:22 -0400 From: Arnd Bergmann To: Wan Zongshun Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Wan Zongshun , Daniel Lezcano , Russell King , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Date: Tue, 05 Jul 2016 10:09:42 +0200 Message-ID: <4905263.SDvl9l5FN0@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <577B660D.50908@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <8706947.5rzUDVsB2F@wuerfel> <577B660D.50908@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:UMAkMYDrz1ZRBh8DjxmtI3G6Ho5+bEMvqx2t2hRG58NCQtu5+kv sxKH4BgWzrpuAurZcAVerIWpfSsEMk1urMGyuHaYUg7mrXAu/HN2az7SGW/fYQovqtO/ls3 qv8oqwx/3M4yzm+FeT6mHu48oPkLkVwEzFqeWwCEC8tLraqVQ1QW15HW+1S258mIiN/w/fH TmE7SHRGmR5dp+/kZh1iA== X-UI-Out-Filterresults: notjunk:1;V01:K0:0LxJujMUX44=:eyQSl51yFyAm1qepalB0Jw hVqzdo/Lr5abN+MgnA3fz+p8CGUgPhWWytVtYvrQt3HbcwoCYVUXlZryghlnnrYChRhyUPfX7 NwM0kXpUFU10kZHhvRgsXjX7TKsuLshB5nRDUC4okUqqslZu0NlQyUVumf1S9cPOB3cu7ri+I Mw4vZgMHIR3yNVbx9lTxx/Y5K3VRNazMKzPWPV2wrCHepPe7DlQzuQiaCI5c/jlBALM/3JdDM HNm70MKHQQ2cMyujCc/zS/aYXo6aPzZsJkWgInlVir/hLNiAy6J+cjZaPNeQwsVUShaWKRtQo aU7nbeR1/UClSwTvz4Ma+ZPHGtCwyvLycZCGzuASGPjCS7znP6oBWe3KjiQFpfVXc1hIv+BdD XFVmEwEiybqImNoytrOz0x3ICRcKk8j/bSGsx5LiUjFJ4LOBIgQC8ou58SlZWaj+b9DANpGJR g8DUiyg0YWfjBKkKRmD21o+3W6LfvifgpDZ25lVsqO1qKqIUaf1FZuULMruPank1vacZ8rSf1 oYUR/GtgDl/4qO4BF2hben5QUD8srEpXL6+okDLajcK0bOBXYmqEPdqX8KnBlMP/ZkWJE8DD6 jtZWpRArl4lOx8BjxZwDB3mMh0hEhV8yenBHYGFHv7SCQeNOJQVpOdBdC4M0pByANvEF6LSFw EGV2/4xE1DEih3Mk0Yb6Mac4VKZ26CevL9uF3xBMVj2O/0Mr7vwlREDVmUxFEJrnUNEhQ+aJi 8KfmqVEdGVN+iWGQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 5, 2016 3:47:25 PM CEST Wan Zongshun wrote: > On 2016年06月29日 23:27, Arnd Bergmann wrote: > > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: > >> +#define IRQ_WDT W90X900_IRQ(1) > >> +#define IRQ_WWDT W90X900_IRQ(2) > >> +#define IRQ_LVD W90X900_IRQ(3) > >> +#define IRQ_EXT0 W90X900_IRQ(4) > >> +#define IRQ_EXT1 W90X900_IRQ(5) > >> +#define IRQ_EXT2 W90X900_IRQ(6) > >> +#define IRQ_EXT3 W90X900_IRQ(7) > >> +#define IRQ_EXT4 W90X900_IRQ(8) > >> +#define IRQ_EXT5 W90X900_IRQ(9) > >> +#define IRQ_EXT6 W90X900_IRQ(10) > > > > I'd suggest dropping the list, the contents are now in the dts. > > Do you think I should put one irqmap header file into this > /arch/arm/boot/dts/include/dt-bindings folder, or I should removed those > irqnumber map anywhere, just hardcode the irqnumber in dts file? Just hardcode it. Arnd