From: Sebastian Smolorz <smolorz@domain.hid>
To: wg@domain.hid, xenomai-core <xenomai@xenomai.org>
Subject: [Xenomai-core] CAN filter issues
Date: Mon, 27 Oct 2008 13:29:01 +0100 [thread overview]
Message-ID: <4905B40D.5050109@domain.hid> (raw)
Hi Wolfgang,
we currently face an issue regarding the filtering of CAN messages since
Xenomai 2.4. It was introduced in rev. 2202 (I know it is long ago but
the problem popped up last week). The line in question is
http://www.rts.uni-hannover.de/xenomai/lxr/source/ksrc/drivers/can/rtcan_raw_filter.c?v=2.3.5#064
and
http://www.rts.uni-hannover.de/xenomai/lxr/source/ksrc/drivers/can/rtcan_raw_filter.c?v=2.4.4#062
respectively.
What worries me is the removal of the AND-operation (can_id & can_mask).
From my POV this offends the CAN specification which says that the CAN
filter mask shall indicate which bits are taken into account when
comparing a CAN identifier and which shall be seen as "don't care".
From your Changelog entry the reason for this modification was to be up
to date with the Linux Socket CAN project. So maybe there is also the
need to bring up this topic on their ML, too.
--
Sebastian
next reply other threads:[~2008-10-27 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 12:29 Sebastian Smolorz [this message]
2008-10-28 19:34 ` [Xenomai-core] CAN filter issues Jan Kiszka
2008-10-28 20:14 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4905B40D.5050109@domain.hid \
--to=smolorz@domain.hid \
--cc=wg@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.