[Qemu-devel] Re: Preliminary patch to implement ehci

[Jan Kiszka <jan.kiszka@siemens.com>]

Glauber Costa wrote:
> On Mon, Oct 27, 2008 at 12:00 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> Mark Burkley wrote:
>>> Hi folks,
>>>
>>> Just checking, did anyone get a chance to look at this?
>>>
>>> Any suggestions for next steps?  Should I post a patch against trunk?
>>>
>> Submitting the patch against 0.9.1 is a non-starter.  0.9.1 is at least a
>> year old and the USB code has been majorly refactored.  If you want people
>> to review it, it has to be against trunk.
>>
>> Also make sure that you include a [PATCH] in your subject.  Otherwise, it's
>> easily missed on the list.
> The chances of anyone reviewing a patch that big is also very small.
> So please, split it in minor, self-contained patches so it make it
> easier for reviewers.

As this patch mostly adds a new implementation, I'm not sure if that
request matches here.

But I have two further remarks:
 - Ensure that your patch is not line-wrapped (maybe you have to switch
   your mail client, dunno if Outlook is "fixable")
 - Adopt your patch to the coding style you find in other qemu files
   (check at least two so that you don't accidentally pick a bad example
    ;) )

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux