From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jeff@garzik.org>
Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTPS id 28CD4DDDF6
	for <linuxppc-dev@ozlabs.org>; Tue, 28 Oct 2008 05:52:51 +1100 (EST)
Message-ID: <49060DFA.7090901@garzik.org>
Date: Mon, 27 Oct 2008 14:52:42 -0400
From: Jeff Garzik <jeff@garzik.org>
MIME-Version: 1.0
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Subject: Re: [PATCH] ibm_newemac: Fix typo in flow control config option
References: <20081024135314.GA2299@yoda.jdub.homelinux.org>
In-Reply-To: <20081024135314.GA2299@yoda.jdub.homelinux.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Cc: netdev@vger.kernel.org, hch@lst.de, linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

Josh Boyer wrote:
> The recent build fix for ibm_newemac has a typo in the config
> option #ifdef used for disabling flow control.  This corrects
> it to the proper Kconfig option name.
> 
> Reported-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
> 
> ---
> 
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index 2ee2622..901212a 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -2605,7 +2605,7 @@ static int __devinit emac_init_config(struct emac_instance *dev)
>  		    of_device_is_compatible(np, "ibm,emac-440gr"))
>  			dev->features |= EMAC_FTR_440EP_PHY_CLK_FIX;
>  		if (of_device_is_compatible(np, "ibm,emac-405ez")) {
> -#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
> +#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL
>  			dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
>  #else
>  			printk(KERN_ERR "%s: Flow control not disabled!\n",

applied