From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk,
linux-embedded@vger.kernel.org
Subject: Re: [PATCH] phylib: add mdio-gpio bus driver (v2)
Date: Tue, 28 Oct 2008 09:37:51 +0200 [thread overview]
Message-ID: <4906C14F.6000305@teltonika.lt> (raw)
In-Reply-To: <8bd0f97a0810270753m740a2295i492532f055f13b17@mail.gmail.com>
Mike Frysinger wrote:
> On Mon, Oct 27, 2008 at 06:53, Paulius Zaleckas wrote:
>> + new_bus->irq = kmalloc(sizeof(int) * PHY_MAX_ADDR, GFP_KERNEL);
>
> oh, and this should be kcalloc()
Why? kcalloc() fills allocated memory with zeros and in this case it has
to be filled with -1... this is done by further for() routine. I don't
see the point to fill it with zeros before...
> -mike
next prev parent reply other threads:[~2008-10-28 7:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 10:53 [PATCH] phylib: add mdio-gpio bus driver (v2) Paulius Zaleckas
2008-10-27 14:37 ` Grant Likely
2008-10-27 16:41 ` David Brownell
2008-10-28 8:55 ` Paulius Zaleckas
2008-10-28 7:46 ` Paulius Zaleckas
2008-10-28 13:08 ` Grant Likely
2008-10-28 15:17 ` Russell King - ARM Linux
2008-10-28 15:30 ` Grant Likely
2008-10-28 16:16 ` Russell King - ARM Linux
2008-10-27 14:52 ` Mike Frysinger
2008-10-28 8:30 ` Paulius Zaleckas
2008-10-28 10:07 ` Mike Frysinger
2008-10-27 14:53 ` Mike Frysinger
2008-10-28 7:37 ` Paulius Zaleckas [this message]
2008-10-28 7:41 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4906C14F.6000305@teltonika.lt \
--to=paulius.zaleckas@teltonika.lt \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-embedded@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.