From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/6] qemu: piix: Introduce functions to get pin number from irq and vice versa Date: Tue, 28 Oct 2008 12:46:39 +0200 Message-ID: <4906ED8F.3040608@redhat.com> References: <1224861988-22781-1-git-send-email-amit.shah@redhat.com> <1224861988-22781-2-git-send-email-amit.shah@redhat.com> <1224861988-22781-3-git-send-email-amit.shah@redhat.com> <1224861988-22781-4-git-send-email-amit.shah@redhat.com> <4904712C.1080307@redhat.com> <20081028101252.GG7102@il.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Amit Shah , kvm@vger.kernel.org, anthony@codemonkey.ws, weidong.han@intel.com, allen.m.kay@intel.com, Ben-Ami Yassour1 To: Muli Ben-Yehuda Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42454 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752357AbYJ1ObK (ORCPT ); Tue, 28 Oct 2008 10:31:10 -0400 In-Reply-To: <20081028101252.GG7102@il.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Muli Ben-Yehuda wrote: > On Sun, Oct 26, 2008 at 03:31:24PM +0200, Avi Kivity wrote: > >> Amit Shah wrote: >> >>> +int piix3_get_pin(int pic_irq) >>> +{ >>> + int i; >>> + for (i = 0; i < 4; i++) >>> + if (piix3_dev->config[0x60+i] == pic_irq) >>> + return i; >>> + return -1; >>> +} >>> >>> >> What happens if two pci interrupts are routed to one irq line? >> > > This one I'm still thinking about. > Well, what is this needed for in the first place? -- error compiling committee.c: too many arguments to function