From: Avi Kivity <avi@redhat.com>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] x86 emulator: move skip_emulated_instruction()
Date: Tue, 28 Oct 2008 12:49:39 +0200 [thread overview]
Message-ID: <4906EE43.2010601@redhat.com> (raw)
In-Reply-To: <20081028105130.372783d8@frecb000711>
Guillaume Thouvenin wrote:
> If we call the emulator we shouldn't call skip_emulated_instruction()
> in the first place, since the emulator already computes the next rip
> for us. Thus we move ->skip_emulated_instruction() out of
> kvm_emulate_pio() and into handle_io() (and the svm equivalent). We
> also replaced "return 0" by "break" in the "do_io:" case because now
> the shadow register state needs to be committed. Otherwise eip will never
> be updated.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-10-28 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 9:51 [PATCH] x86 emulator: move skip_emulated_instruction() Guillaume Thouvenin
2008-10-28 10:49 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4906EE43.2010601@redhat.com \
--to=avi@redhat.com \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.