Re: Request for test (1.0.18 final)

[Clemens Ladisch <clemens@ladisch.de>]

Takashi Iwai wrote:
> IIRC, the hack was needed at the time alsa-driver's kconfig parser
> didn't parse the tea575x dependency correctly.  So, the whole hack should
> be removed now.
>
> How about the patch below?
>
> --- a/i2c/other/Makefile
> +++ b/i2c/other/Makefile
> @@ -5,17 +5,8 @@ endif
>  include $(SND_TOPDIR)/toplevel.config
>  include $(SND_TOPDIR)/Makefile.conf
>
> -export-objs += ak4xxx-adda.o ak4114.o ak4117.o pt2258.o
> -
> -# Toplevel Module Dependency
> -# hack for tea575x support
> -ifeq (y,$(CONFIG_VIDEO_DEV))
> -obj-$(CONFIG_SND_FM801) += snd-tea575x-tuner.o
> -ifeq (m,$(CONFIG_SND_FM801))
> -export-objs += tea575x-tuner.o
> +export-objs += ak4xxx-adda.o ak4114.o ak4117.o pt2258.o tea575x-tuner.o
>  clean-files += tea575x-tuner.c
> -endif
> -endif
>
>  include $(SND_TOPDIR)/alsa-kernel/i2c/other/Makefile

AFAICS snd-tea575x-tuner is not compiled at all; it should have:

obj-$(CONFIG_SND_FM801_TEA575X) += snd-tea575x-tuner.o

And it looks as if the usual dependencies for patched files are missing:

tea575x-tuner.c: tea575x-tuner.patch $(SND_TOPDIR)/alsa-kernel/i2c/other/tea575x-tuner.c


Regards,
Clemens