From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/6] qemu: piix: Introduce functions to get pin number from irq and vice versa Date: Tue, 28 Oct 2008 18:21:35 +0200 Message-ID: <49073C0F.3050805@redhat.com> References: <1224861988-22781-1-git-send-email-amit.shah@redhat.com> <1224861988-22781-2-git-send-email-amit.shah@redhat.com> <1224861988-22781-3-git-send-email-amit.shah@redhat.com> <1224861988-22781-4-git-send-email-amit.shah@redhat.com> <4904712C.1080307@redhat.com> <20081028101252.GG7102@il.ibm.com> <4906ED8F.3040608@redhat.com> <20081028154458.GC6737@il.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Amit Shah , kvm@vger.kernel.org, anthony@codemonkey.ws, weidong.han@intel.com, allen.m.kay@intel.com, Ben-Ami Yassour1 To: Muli Ben-Yehuda Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38108 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbYJ1QXh (ORCPT ); Tue, 28 Oct 2008 12:23:37 -0400 In-Reply-To: <20081028154458.GC6737@il.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Muli Ben-Yehuda wrote: >> Well, what is this needed for in the first place? >> > > This specific function is not used. I assume Amit added it for > completeness with piix_get_irq. piix_get_irq, as far as I can tell, is > used in only one place (when the guest updates a device's > configuration space interrupt register) to go from interrupt pin > (intx) to guest IRQ line. > In that case, a solution suggests itself... -- error compiling committee.c: too many arguments to function