From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 02/11] net/failsafe: fix sub-device visibility Date: Wed, 09 May 2018 14:21:20 +0200 Message-ID: <4908131.kiA02KnrBr@xps> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509094337.26112-3-thomas@monjalon.net> <20180509121320.qpoixqsoxtlcjyak@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 417241AFEB for ; Wed, 9 May 2018 14:21:22 +0200 (CEST) In-Reply-To: <20180509121320.qpoixqsoxtlcjyak@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/05/2018 14:13, Ga=EBtan Rivet: > I think this patch should be swapped with the next commit > "ethdev: add doxygen comments for each state", > While the comment about "DEFERRED" would be edited in this one to become: > /** The deferred state is deprecated and replaced by ownership. */ > ^^^^^^^^^^ I prefer considering the DEFERRED state as useless in this series. We can discuss about deprecation and removal, separately with a deprecation notice. > Otherwise I agree that the device state is not to be used anymore.