All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: xiaosuo@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] HTB updates class's bstats in one place
Date: Wed, 29 Oct 2008 10:01:01 +0100	[thread overview]
Message-ID: <4908264D.4030206@trash.net> (raw)
In-Reply-To: <490824B3.20100@gmail.com>

Changli Gao wrote:
> This patch make HTB update class's bstats in one place when dequeuing
> packets instead of updating the leaf's when enqueuing and updating the
> other's when dequeuing. It also fixes a statistics bug, the statistics
> data of leaf class will exceeds its parent classes's due to packets are
> dropped by its inner qdisc.

They should actually all be updated in enqueue. The estimators needs
this since they're estimating the arrival rate.


  reply	other threads:[~2008-10-29  9:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29  8:54 [PATCH] HTB updates class's bstats in one place Changli Gao
2008-10-29  9:01 ` Patrick McHardy [this message]
2008-10-29  9:09   ` Changli Gao
2008-10-29  9:19     ` Patrick McHardy
2008-10-29 10:23       ` Jarek Poplawski
2008-10-29 10:33         ` Patrick McHardy
2008-10-29 18:22           ` David Miller
2008-10-30  1:03           ` Changli Gao
2008-10-30  7:11             ` Patrick McHardy
2008-10-30  9:11               ` Changli Gao
2008-10-30  9:21                 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4908264D.4030206@trash.net \
    --to=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.