From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Date: Wed, 29 Oct 2008 12:52:43 +0000 Subject: Re: [PATCH 03/12] x86: Cleanup usage of struct desc_struct Message-Id: <49085C9B.6000905@goop.org> List-Id: References: <> <1224904532-9586-1-git-send-email-ice799@gmail.com> <52f8491fb5d55c0171840b01638ea6db0a98f3be.1224903712.git.ice799@gmail.com> <03269a2e8f455b431612a32e8cce048e98c75b27.1224903712.git.ice799@gmail.com> <4810cc08c12cd78612b53f9b52d7ba93a9b03fd0.1224903712.git.ice799@gmail.com> In-Reply-To: <4810cc08c12cd78612b53f9b52d7ba93a9b03fd0.1224903712.git.ice799@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Damato Cc: linux-x86_64@vger.kernel.org, linux-newbie@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Joe Damato wrote: > Use gate_desc typedef for IDT entries instead of struct desc_struct. > Why's that? In general we try to avoid typedefs unless they're really necessary. If it is necessary, it should be named gate_desc_t. J From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH 03/12] x86: Cleanup usage of struct desc_struct Date: Wed, 29 Oct 2008 23:52:43 +1100 Message-ID: <49085C9B.6000905@goop.org> References: <> <1224904532-9586-1-git-send-email-ice799@gmail.com> <52f8491fb5d55c0171840b01638ea6db0a98f3be.1224903712.git.ice799@gmail.com> <03269a2e8f455b431612a32e8cce048e98c75b27.1224903712.git.ice799@gmail.com> <4810cc08c12cd78612b53f9b52d7ba93a9b03fd0.1224903712.git.ice799@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4810cc08c12cd78612b53f9b52d7ba93a9b03fd0.1224903712.git.ice799@gmail.com> Sender: linux-newbie-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Joe Damato Cc: linux-x86_64@vger.kernel.org, linux-newbie@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Joe Damato wrote: > Use gate_desc typedef for IDT entries instead of struct desc_struct. > Why's that? In general we try to avoid typedefs unless they're really necessary. If it is necessary, it should be named gate_desc_t. J -- To unsubscribe from this list: send the line "unsubscribe linux-newbie" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.linux-learn.org/faqs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753711AbYJ2MxO (ORCPT ); Wed, 29 Oct 2008 08:53:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753507AbYJ2Mwz (ORCPT ); Wed, 29 Oct 2008 08:52:55 -0400 Received: from gw.goop.org ([64.81.55.164]:42264 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbYJ2Mwy (ORCPT ); Wed, 29 Oct 2008 08:52:54 -0400 Message-ID: <49085C9B.6000905@goop.org> Date: Wed, 29 Oct 2008 23:52:43 +1100 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.17 (X11/20081009) MIME-Version: 1.0 To: Joe Damato CC: linux-x86_64@vger.kernel.org, linux-newbie@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] x86: Cleanup usage of struct desc_struct References: <> <1224904532-9586-1-git-send-email-ice799@gmail.com> <52f8491fb5d55c0171840b01638ea6db0a98f3be.1224903712.git.ice799@gmail.com> <03269a2e8f455b431612a32e8cce048e98c75b27.1224903712.git.ice799@gmail.com> <4810cc08c12cd78612b53f9b52d7ba93a9b03fd0.1224903712.git.ice799@gmail.com> In-Reply-To: <4810cc08c12cd78612b53f9b52d7ba93a9b03fd0.1224903712.git.ice799@gmail.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Damato wrote: > Use gate_desc typedef for IDT entries instead of struct desc_struct. > Why's that? In general we try to avoid typedefs unless they're really necessary. If it is necessary, it should be named gate_desc_t. J