All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Jay Cliburn <jcliburn@gmail.com>, netdev@vger.kernel.org
Subject: Re: atl1 warn_on_slowpath help
Date: Wed, 29 Oct 2008 17:40:54 +0100	[thread overview]
Message-ID: <49089216.3010607@trash.net> (raw)
In-Reply-To: <20081029140404.GC7256@ff.dom.local>

Jarek Poplawski wrote:
> On Wed, Oct 29, 2008 at 02:26:50PM +0100, Patrick McHardy wrote:
> ...
>> I still don't follow - are you talking about the code with out
>> without this patch? In the later case, why should we call it
>> recursively without the need to do so?
> 
> I mean the current version (e.g. net-2.6). This comment reads that
> netif_nit_deliver() is needed when we bypass netif_receive_skb().
> But we call netif_receive_skb() from __vlan_hwaccel_rx(), and it's
> not clear if some skbs are not tapped 2x.

They could be, but in different states (device, vlan_tci, priority).
Bypassing refers to the first state of the skb.

      reply	other threads:[~2008-10-29 16:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29  0:08 atl1 warn_on_slowpath help Jay Cliburn
2008-10-29  7:15 ` Jarek Poplawski
2008-10-29  8:12   ` Patrick McHardy
2008-10-29 10:17     ` Patrick McHardy
2008-10-29 12:51       ` J. K. Cliburn
2008-10-29 12:54         ` Patrick McHardy
2008-10-29 14:15         ` Ramon Casellas
2008-10-29 16:47           ` Patrick McHardy
2008-10-29 13:03       ` Jarek Poplawski
2008-10-29 13:09         ` Patrick McHardy
2008-10-29 13:22           ` Jarek Poplawski
2008-10-29 13:26             ` Patrick McHardy
2008-10-29 14:04               ` Jarek Poplawski
2008-10-29 16:40                 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49089216.3010607@trash.net \
    --to=kaber@trash.net \
    --cc=jarkao2@gmail.com \
    --cc=jcliburn@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.