From: roel kluin <roel.kluin@gmail.com>
To: len.brown@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] intel_menlo: max_state is unsigned, invalid test
Date: Wed, 29 Oct 2008 17:06:47 -0400 [thread overview]
Message-ID: <4908D067.9080207@gmail.com> (raw)
max_state is unsigned, so the test is invalid.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
I think max_state can only become -1, no? then probably a different
patch is required.
I may not be able to respond for a few weeks.
diff --git a/drivers/misc/intel_menlow.c b/drivers/misc/intel_menlow.c
index e00a275..980171d 100644
--- a/drivers/misc/intel_menlow.c
+++ b/drivers/misc/intel_menlow.c
@@ -121,7 +121,7 @@ static int memory_set_cur_bandwidth(struct thermal_cooling_device *cdev,
if (memory_get_int_max_bandwidth(cdev, &max_state))
return -EFAULT;
- if (max_state < 0 || state > max_state)
+ if (max_state == -1 || state > max_state)
return -EINVAL;
arg_list.count = 1;
next reply other threads:[~2008-10-29 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:06 roel kluin [this message]
2008-11-03 22:35 ` [PATCH] intel_menlo: max_state is unsigned, invalid test Andrew Morton
2008-11-04 4:07 ` Len Brown
2008-11-05 10:20 ` Thomas, Sujith
2008-11-05 10:20 ` Thomas, Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4908D067.9080207@gmail.com \
--to=roel.kluin@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.