From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.27]) by ozlabs.org (Postfix) with ESMTP id B6209DDDFB for ; Thu, 30 Oct 2008 08:43:48 +1100 (EST) Received: by qw-out-2122.google.com with SMTP id 9so223385qwb.15 for ; Wed, 29 Oct 2008 14:43:47 -0700 (PDT) Message-ID: <4908D912.8010003@genesi-usa.com> Date: Wed, 29 Oct 2008 16:43:46 -0500 From: Matt Sealey MIME-Version: 1.0 To: Scott Wood , Stephen Hemminger , netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2] net: add PCINet driver References: <20081029202027.GH12879@ovro.caltech.edu> <20081029132506.55b93555@extreme> <20081029205002.GI12879@ovro.caltech.edu> <4908CD96.300@freescale.com> <20081029211312.GJ12879@ovro.caltech.edu> In-Reply-To: <20081029211312.GJ12879@ovro.caltech.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: Matt Sealey List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ira Snyder wrote: > > I'll go ahead change the typedef to a struct. Hopefully some of the > other inspiration I took wasn't too bad. I'm totally open to suggestions > on improvements for this driver. Not a suggestion for improvement, but I have to say this is by far the single coolest thing I have EVER seen submitted to mainline :) -- Matt Sealey Genesi, Manager, Developer Relations