From: Lachlan McIlroy <lachlan@sgi.com>
To: Lachlan McIlroy <lachlan@sgi.com>,
Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: assertion failure with latest xfs
Date: Thu, 30 Oct 2008 13:29:16 +1100 [thread overview]
Message-ID: <49091BFC.3000503@sgi.com> (raw)
In-Reply-To: <20081029032941.GG4985@disturbed>
Dave Chinner wrote:
> On Wed, Oct 29, 2008 at 11:43:31AM +1100, Lachlan McIlroy wrote:
>> Dave Chinner wrote:
>>> Hmmmm - there's also another bug in xfs_iget_cache_hit() - we don't
>>> drop the reference we got if we found an unlinked inode after the
>>> igrab() (the ENOENT case). I'll fix that as well.
>>>
>>> Patch below that I'm currently running through xfsqa.
>> I gave this patch a go and it still asserted at the same place running
>> the same test.
>
> Can you put more inode trace points in so that we can see where the
> extra reference is coming from?
xfs_sync_inodes_ag() found the inode before it was completely
initialised.
--> itrace @ 0xffff880078d67800/0xffff880073563e40
ref @fs/xfs/xfs_inode.c:863(xfs_inode_alloc+0x205) i_count = 1
cpu = 2 pid = 9938 ra = xfs_iread+0x29
exit from xfs_iget.alloc i_count = 1
cpu = 2 pid = 9938 ra = xfs_trans_iget+0x205
ref @fs/xfs/xfs_iget.c:218(xfs_iget+0x585) i_count = 1
cpu = 2 pid = 9938 ra = xfs_trans_iget+0x205
ref @fs/xfs/xfs_iget.c:305(xfs_iget+0x643) i_count = 1
cpu = 2 pid = 9938 ra = xfs_trans_iget+0x205
ref @fs/xfs/linux-2.6/xfs_sync.c:113(xfs_sync_inodes_ag+0x118) i_count = 1
cpu = 3 pid = 9953 ra = xfs_sync_inodes+0x68
ref @fs/xfs/linux-2.6/xfs_iops.c:780(xfs_setup_inode+0x2c) i_count = 2
cpu = 2 pid = 9938 ra = xfs_ialloc+0x5d8
next prev parent reply other threads:[~2008-10-30 2:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 9:08 assertion failure with latest xfs Lachlan McIlroy
2008-10-23 17:31 ` Christoph Hellwig
2008-10-23 22:21 ` Dave Chinner
2008-10-29 0:43 ` Lachlan McIlroy
2008-10-29 3:29 ` Dave Chinner
2008-10-30 2:29 ` Lachlan McIlroy [this message]
2008-10-30 5:38 ` Dave Chinner
2008-10-31 1:09 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49091BFC.3000503@sgi.com \
--to=lachlan@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.