From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.redhat.com ([66.187.237.31]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KvSBT-0005Dx-Vv for kexec@lists.infradead.org; Thu, 30 Oct 2008 07:43:12 +0000 Message-ID: <49096597.1030800@redhat.com> Date: Thu, 30 Oct 2008 09:43:19 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH 0/2] kvm: disable virtualization on kdump References: <4904676F.3020706@redhat.com> <490487C1.1010707@redhat.com> <20081026213927.GF23893@blackpad> <49058645.9010005@redhat.com> <20081027122808.GH23893@blackpad> <4905C9ED.807@redhat.com> <20081028194530.GK23893@blackpad> <49082FD0.3040009@redhat.com> <4908975A.7050900@redhat.com> <490963DF.90703@redhat.com> In-Reply-To: <490963DF.90703@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Chris Lalancette Cc: Andrew Morton , Eduardo Habkost , kvm@vger.kernel.org, kexec@lists.infradead.org, Haren Myneni , Simon Horman , "Eric W. Biederman" , Vivek Goyal Chris Lalancette wrote: > I'm pretty sure you have to test for it first; pre-64 bit x86 hardware doesn't > have the EFER register, so you'll fault on access. On the other hand pre-64 bit > x86 hardware doesn't usually (ever?) have VT extensions either. > All amd hardware that supports svm has an efer. Some Intel hardware doesn't, but we don't care in that case. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/2] kvm: disable virtualization on kdump Date: Thu, 30 Oct 2008 09:43:19 +0200 Message-ID: <49096597.1030800@redhat.com> References: <4904676F.3020706@redhat.com> <490487C1.1010707@redhat.com> <20081026213927.GF23893@blackpad> <49058645.9010005@redhat.com> <20081027122808.GH23893@blackpad> <4905C9ED.807@redhat.com> <20081028194530.GK23893@blackpad> <49082FD0.3040009@redhat.com> <4908975A.7050900@redhat.com> <490963DF.90703@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Eduardo Habkost , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Haren Myneni , Simon Horman , "Eric W. Biederman" , Vivek Goyal To: Chris Lalancette Return-path: In-Reply-To: <490963DF.90703-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org Chris Lalancette wrote: > I'm pretty sure you have to test for it first; pre-64 bit x86 hardware doesn't > have the EFER register, so you'll fault on access. On the other hand pre-64 bit > x86 hardware doesn't usually (ever?) have VT extensions either. > All amd hardware that supports svm has an efer. Some Intel hardware doesn't, but we don't care in that case. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.