From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH] x86: fix preemptable page type handling(v2)
Date: Thu, 30 Oct 2008 14:56:00 +0000
Message-ID: <4909D910.76E4.0078.0@novell.com>
References: <4909B652.76E4.0078.0@novell.com>
	<C52F7961.28970%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C52F7961.28970%keir.fraser@eu.citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>>> Keir Fraser <keir.fraser@eu.citrix.com> 30.10.08 15:46 >>>
>Why does this patch not do what the new comment says and directly =
get_page()
>when PGT_partial is set and put_page() when PGT_partial is cleared? Doing

Hmm, the description was meant to tell the net effect, not the way it's
implemented.

>get_page() across all __put_page() operations and then skipping the
>put_page() in some cases, for example, seems inefficient and also makes =
the
>code less clear. Why would you do it that way?

Because I can't handle a failure of get_page() (due to count overflow)
once I'm past the put()s.

Jan