From: Dave <kilroyd@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
John Linville <linville@tuxdriver.com>,
wireless <linux-wireless@vger.kernel.org>,
Hin-Tak Leung <htl10@users.sourceforge.net>,
Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Subject: Re: Guidelines regarding separate directory
Date: Thu, 30 Oct 2008 20:24:19 +0000 [thread overview]
Message-ID: <490A17F3.5050802@gmail.com> (raw)
In-Reply-To: <1225387309.3690.73.camel@johannes.berg>
Johannes Berg wrote:
> On Thu, 2008-10-30 at 10:10 -0700, Larry Finger wrote:
>> I am planning on adding code to control the LEDs on the RTL8187 devices based on
>> the latest vendor driver. From the expected size of the code, I think that
>> separate files will be best.
>>
>> What number of files in a driver make it advisable to create a separate
>> directory? Between the rtl8180 and rtl8187 drivers, there are now 15 files and I
>> will be adding at least 2 more. Is this the time to create a rtl818x directory
>> under drivers/net/wireless?
>
> I for one think that should have been done already, makes finding
> drivers easier imho. But I don't think there are strict guidelines in
> any way.
On a similar note, would anyone object to collecting the orinoco files
in a subdirectory? I'm looking at doing some refactoring of orinoco.c
which I think can be split into at least 3 files.
Regards,
Dave.
PS the existing files that would move:
airport.c
hermes.c
hermes.h
hermes_dld.c
hermes_dld.h
hermes_rid.h
orinoco.c
orinoco.h
orinoco_cs.c
orinoco_pci.c
orinoco_pci.h
orinoco_plx.c
orinoco_tmd.c
orinoco_nortel.c
spectrum_cs.c
next prev parent reply other threads:[~2008-10-30 20:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 17:10 Guidelines regarding separate directory Larry Finger
2008-10-30 17:21 ` Johannes Berg
2008-10-30 20:24 ` Dave [this message]
2008-10-30 20:26 ` Johannes Berg
2008-10-30 20:44 ` Pavel Roskin
2008-10-30 20:48 ` Johannes Berg
2008-10-31 3:10 ` Pavel Roskin
2008-10-31 10:01 ` Johannes Berg
2008-10-31 16:01 ` Pavel Roskin
2008-10-31 16:13 ` Dan Williams
2008-10-31 16:24 ` Johannes Berg
2008-10-31 17:04 ` Richard Farina
2008-10-31 17:41 ` Pavel Roskin
2008-10-31 19:06 ` Richard Farina
2008-11-04 0:28 ` Pavel Roskin
2008-10-30 20:50 ` Dave
2008-10-30 17:29 ` John W. Linville
2008-10-30 23:47 ` Larry Finger
2008-10-31 10:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490A17F3.5050802@gmail.com \
--to=kilroyd@googlemail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.