All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: Elias Oltmanns <eo@nebensachen.de>, linux-ide@vger.kernel.org
Subject: Re: libata: Fix a potential race condition in ata_scsi_park_show()
Date: Fri, 31 Oct 2008 01:40:39 -0400	[thread overview]
Message-ID: <490A9A57.5040001@garzik.org> (raw)
In-Reply-To: <490A6CE2.6080706@kernel.org>

Tejun Heo wrote:
> Elias Oltmanns wrote:
>> Tejun Heo <tj@kernel.org> wrote:
>>> Elias Oltmanns wrote:
>>>> Peter Moulder has pointed out that there is a slight chance that a
>>>> negative value might be passed to jiffies_to_msecs() in
>>>> ata_scsi_park_show(). This is fixed by saving the value of jiffies in a
>>>> local variable, thus also reducing code since the volatile variable
>>>> jiffies is accessed only once.
>>>>
>>>> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
>>> added to #tj-upstream.  Thanks.
>> Has this branch been pulled in yet? My patch, for one, is not even in
>> linux-next even though it had been intended for 2.6.28 at the time.
> 
> Jeff, have you pulled it or taken patches from it?
> 
> Thanks.

I sent an email a couple days ago, asking what was pending (or thought I 
did...).  I haven't pulled from #tj-upstream but I ack'd a big patchset 
that I assume is included in there.

	Jeff




  reply	other threads:[~2008-10-31  5:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-04  9:41 libata: Fix a potential race condition in ata_scsi_park_show() Elias Oltmanns
2008-10-04 20:17 ` Tejun Heo
2008-10-30 21:39   ` Elias Oltmanns
2008-10-31  2:26     ` Tejun Heo
2008-10-31  5:40       ` Jeff Garzik [this message]
2008-11-03  9:54         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490A9A57.5040001@garzik.org \
    --to=jeff@garzik.org \
    --cc=eo@nebensachen.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.