From: Jeff Garzik <jgarzik@pobox.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: ide <linux-ide@vger.kernel.org>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 5/7] ATA: remove excess kernel-doc notation
Date: Fri, 31 Oct 2008 01:45:56 -0400 [thread overview]
Message-ID: <490A9B94.2010805@pobox.com> (raw)
In-Reply-To: <20081029223508.c824f8dc.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Remove excess kernel-doc function parameter notation from drivers/ata/:
>
> Warning(drivers/ata/libata-core.c:1622): Excess function parameter or struct member 'fn' description in 'ata_pio_queue_task'
> Warning(drivers/ata/libata-core.c:4655): Excess function parameter or struct member 'err_mask' description in 'ata_qc_complete'
> Warning(drivers/ata/ata_piix.c:751): Excess function parameter or struct member 'udma' description in 'do_pata_set_dmamode'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/ata/ata_piix.c | 1 -
> drivers/ata/libata-core.c | 2 --
> 2 files changed, 3 deletions(-)
>
> --- lin2628-rc2.orig/drivers/ata/ata_piix.c
> +++ lin2628-rc2/drivers/ata/ata_piix.c
> @@ -738,7 +738,6 @@ static void piix_set_piomode(struct ata_
> * do_pata_set_dmamode - Initialize host controller PATA PIO timings
> * @ap: Port whose timings we are configuring
> * @adev: Drive in question
> - * @udma: udma mode, 0 - 6
> * @isich: set if the chip is an ICH device
> *
> * Set UDMA mode for device, in host controller PCI config space.
> --- lin2628-rc2.orig/drivers/ata/libata-core.c
> +++ lin2628-rc2/drivers/ata/libata-core.c
> @@ -1602,7 +1602,6 @@ unsigned long ata_id_xfermask(const u16
> /**
> * ata_pio_queue_task - Queue port_task
> * @ap: The ata_port to queue port_task for
> - * @fn: workqueue function to be scheduled
> * @data: data for @fn to use
> * @delay: delay time in msecs for workqueue function
> *
> @@ -4643,7 +4642,6 @@ static void ata_verify_xfer(struct ata_q
> /**
> * ata_qc_complete - Complete an active ATA command
> * @qc: Command to complete
> - * @err_mask: ATA Status register contents
> *
> * Indicate to the mid and upper layers that an ATA
applied
prev parent reply other threads:[~2008-10-31 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 5:35 [PATCH 5/7] ATA: remove excess kernel-doc notation Randy Dunlap
2008-10-31 5:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490A9B94.2010805@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.