Re: [Patch 2/3] New blktap implementation

[Kevin Wolf <kwolf@suse.de>]

Dutch Meyer schrieb:
> Patch 2 of 3.
> 
> Signed-off-by: Jake Wires <jake.wires@citrix.com>, Dutch Meyer
> <dmeyer@cs.ubc.ca>
> 
> This is a new and rewritten version of blktap that we have developed at
> Citrix.  The current version of blktap is left functionally unmodified.
> The change set consists of three patches.

You only have attached a fixqcow patch, no blktap rewrite.

Could you explain what the qcow patch is supposed to fix? I think we
need good reasons to change this code because every change increases the
differences between the tapdisk and qemu implementation of the format.
It was agreed that eventually we want to get rid of the tapdisk
implementation of the formats qemu can provide, but in the meantime we
should at least be careful not to increase differences.

If these are real fixes, maybe they should also go into upstream qemu?

Kevin