All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
	Paul Menage <menage@google.com>,
	lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	David Rientjes <rientjes@google.com>,
	Pavel Emelianov <xemul@openvz.org>,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector
Date: Sun, 02 Nov 2008 11:33:51 +0530	[thread overview]
Message-ID: <490D42C7.4000301@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081102143817.99edca6d.kamezawa.hiroyu@jp.fujitsu.com>

KAMEZAWA Hiroyuki wrote:
> On Sun, 02 Nov 2008 00:19:02 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> 
>> Don't enable multiple hierarchy support by default. This patch introduces
>> a features element that can be set to enable the nested depth hierarchy
>> feature. This feature can only be enabled when there is just one cgroup
>> (the root cgroup).
>>
> Why the flag is for the whole system ?
> flag-per-subtree is of no use ?

Flag per subtree might not be useful, since we charge all the way up to root,
which means that all subtrees have the root cgroup and hence the global flag.

Thanks for the comments,

-- 
	Balbir

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
	Paul Menage <menage@google.com>,
	lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	David Rientjes <rientjes@google.com>,
	Pavel Emelianov <xemul@openvz.org>,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector
Date: Sun, 02 Nov 2008 11:33:51 +0530	[thread overview]
Message-ID: <490D42C7.4000301@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081102143817.99edca6d.kamezawa.hiroyu@jp.fujitsu.com>

KAMEZAWA Hiroyuki wrote:
> On Sun, 02 Nov 2008 00:19:02 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> 
>> Don't enable multiple hierarchy support by default. This patch introduces
>> a features element that can be set to enable the nested depth hierarchy
>> feature. This feature can only be enabled when there is just one cgroup
>> (the root cgroup).
>>
> Why the flag is for the whole system ?
> flag-per-subtree is of no use ?

Flag per subtree might not be useful, since we charge all the way up to root,
which means that all subtrees have the root cgroup and hence the global flag.

Thanks for the comments,

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-11-02  6:04 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-01 18:48 [mm][PATCH 0/4] Memory cgroup hierarchy introduction Balbir Singh
2008-11-01 18:48 ` Balbir Singh
2008-11-01 18:48 ` [mm] [PATCH 1/4] Memory cgroup hierarchy documentation Balbir Singh
2008-11-01 18:48   ` Balbir Singh
2008-11-04  6:25   ` Paul Menage
2008-11-04  6:25     ` Paul Menage
2008-11-04  6:26     ` Paul Menage
2008-11-04  6:26       ` Paul Menage
2008-11-05 13:55       ` Balbir Singh
2008-11-05 13:55         ` Balbir Singh
2008-11-01 18:48 ` [mm] [PATCH 2/4] Memory cgroup resource counters for hierarchy Balbir Singh
2008-11-01 18:48   ` Balbir Singh
2008-11-02  5:42   ` KAMEZAWA Hiroyuki
2008-11-02  5:42     ` KAMEZAWA Hiroyuki
2008-11-02  5:49     ` Balbir Singh
2008-11-02  5:49       ` Balbir Singh
2008-11-02  5:56       ` KAMEZAWA Hiroyuki
2008-11-02  5:56         ` KAMEZAWA Hiroyuki
2008-11-02 11:46         ` Balbir Singh
2008-11-02 11:46           ` Balbir Singh
2008-11-01 18:48 ` [mm] [PATCH 3/4] Memory cgroup hierarchical reclaim Balbir Singh
2008-11-01 18:48   ` Balbir Singh
2008-11-02  5:37   ` KAMEZAWA Hiroyuki
2008-11-02  5:37     ` KAMEZAWA Hiroyuki
2008-11-02  5:44     ` Balbir Singh
2008-11-02  5:44       ` Balbir Singh
2008-11-04  2:17       ` KAMEZAWA Hiroyuki
2008-11-04  2:17         ` KAMEZAWA Hiroyuki
2008-11-05 13:34         ` Balbir Singh
2008-11-05 13:34           ` Balbir Singh
2008-11-05 16:20           ` KAMEZAWA Hiroyuki
2008-11-05 16:20             ` KAMEZAWA Hiroyuki
2008-11-06 14:00             ` Balbir Singh
2008-11-06 14:00               ` Balbir Singh
2008-11-01 18:49 ` [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector Balbir Singh
2008-11-01 18:49   ` Balbir Singh
2008-11-02  5:38   ` KAMEZAWA Hiroyuki
2008-11-02  5:38     ` KAMEZAWA Hiroyuki
2008-11-02  6:03     ` Balbir Singh [this message]
2008-11-02  6:03       ` Balbir Singh
2008-11-02  6:24       ` KAMEZAWA Hiroyuki
2008-11-02  6:24         ` KAMEZAWA Hiroyuki
2008-11-02 15:52         ` Balbir Singh
2008-11-02 15:52           ` Balbir Singh
2008-11-04  6:37           ` Paul Menage
2008-11-04  6:37             ` Paul Menage
2008-11-06  7:00             ` Balbir Singh
2008-11-06  7:00               ` Balbir Singh
2008-11-06  7:01               ` Balbir Singh
2008-11-06  7:01                 ` Balbir Singh
2008-11-06  6:56         ` Balbir Singh
2008-11-06  6:56           ` Balbir Singh
2008-11-06  7:30           ` KAMEZAWA Hiroyuki
2008-11-06  7:30             ` KAMEZAWA Hiroyuki
2008-11-04  0:15 ` [mm][PATCH 0/4] Memory cgroup hierarchy introduction KAMEZAWA Hiroyuki
2008-11-04  0:15   ` KAMEZAWA Hiroyuki
2008-11-05 13:51   ` Balbir Singh
2008-11-05 13:51     ` Balbir Singh
2008-11-05 16:33     ` KAMEZAWA Hiroyuki
2008-11-05 16:33       ` KAMEZAWA Hiroyuki
2008-11-05 17:52       ` Balbir Singh
2008-11-05 17:52         ` Balbir Singh
2008-11-06  0:22         ` KAMEZAWA Hiroyuki
2008-11-06  0:22           ` KAMEZAWA Hiroyuki
2008-11-04  9:21 ` [patch 1/2] memcg: hierarchy, yet another one KAMEZAWA Hiroyuki
2008-11-04  9:21   ` KAMEZAWA Hiroyuki
2008-11-04  9:25 ` KAMEZAWA Hiroyuki
2008-11-04  9:25   ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490D42C7.4000301@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=nickpiggin@yahoo.com.au \
    --cc=rientjes@google.com \
    --cc=xemul@openvz.org \
    --cc=yamamoto@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.