From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Andrew Gallatin <gallatin@myri.com>
Subject: Re: [PATCH] net: kconfig cleanup
Date: Sun, 02 Nov 2008 08:36:03 -0500 [thread overview]
Message-ID: <490DACC3.2050203@garzik.org> (raw)
In-Reply-To: <20081031074143.25532.6078.stgit@gitlost.lost>
Jeff Kirsher wrote:
> The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this
> patch adds a description to the kconfig option.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: Andrew Gallatin <gallatin@myri.com>
> ---
>
> drivers/net/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f749b40..b13a7ff 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2437,7 +2437,7 @@ config IXGBE
> will be called ixgbe.
>
> config IXGBE_DCA
> - bool
> + bool "Enable DCA"
> default y
> depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
>
> @@ -2489,7 +2489,7 @@ config MYRI10GE
> will be called myri10ge.
>
> config MYRI10GE_DCA
> - bool
> + bool "Enable DCA"
> default y
> depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
If you're gonna do that, please add useful help text for the user who
has no idea what this means. (IGB_DCA needs this as well)
Jeff
prev parent reply other threads:[~2008-11-02 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 7:41 [PATCH] net: kconfig cleanup Jeff Kirsher
2008-11-02 13:36 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490DACC3.2050203@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.