Re: [PATCH] crypto: add test vectors for skein256/512/1024

[Jeff Garzik <jeff@garzik.org>]

Sebastian Andrzej Siewior wrote:
> I grabed them from http://www.schneier.com/skein.html. The last test vector
> (3) in every category is currently deactivated because it failed always.
> It is unlikely that I made a type because I copy+pasted the tables + vim
> magiced them. So maybe code may missbehave on requests lengths which are
> not a multiple of 4 or the vectors can not be used due to some other
> limitations that I've overseen.
> 
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> ---
>  crypto/tcrypt.c  |   24 ++++++++
>  crypto/testmgr.c |   27 +++++++++
>  crypto/testmgr.h |  166 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 216 insertions(+), 1 deletions(-)

Nice, thanks!

I'm wondering if the failure has to do with the alignmask value in 
struct crypto_alg for each variant.

	Jeff