Re: [PATCH 6/7] [sony-laptop] add control over wifi power in Sony laptops

[Sergey Yanovich <ynvich@gmail.com>]

Matthew Garrett wrote:
> On Mon, Nov 03, 2008 at 06:41:19PM +0900, Mattia Dongili wrote:
> 
>> Sony laptops have a single hardware rfkill switch, which controls
>> several wireless devices: wifi, bluetooth, wwan. The code to
>> selectively control bluetooth and wwan is already present. This
>> patch adds handling of wifi.

My Vaio VGN-TX770P has ipw2200, which IIUC understands hardware rfkill 
switch state. At the same time, when there is no wifi network around and 
I am on internal GRPS modem link, I would like global switch to be on, 
but wifi to be off. The main reason is to save power. The device has a 
dedicated key combination for this, on which Windows drivers by Sony 
operates.

> Please don't add more custom radio control switches. It'd be better to 
> add rfkill support. Otherwise we have even more stuff in /sys to carry 
> around for ages before deprecating.

Do you mean that the patch should use some other file instead of 
/sys/devices/platform/sony-laptop/wifipower for input/output?

If so, could you please provide some pointers on what should be done, 
and where in the source tree to look for references?

-- 
Cheers,
Sergey Yanovich