From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik l <jeff@garzik.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Mark Lord <liml@rtr.ca>, Elias Oltmanns <eo@nebensachen.de>
Subject: [PATCH #upstream 2/3] libata: when restoring SControl during detach do the PMP links first
Date: Mon, 03 Nov 2008 20:03:49 +0900 [thread overview]
Message-ID: <490EDA95.6070409@kernel.org> (raw)
In-Reply-To: <490EDA75.5060703@kernel.org>
When restoring SControl during detach, PMP links should be handled
first as changing SControl of the host link can affect SCR access of
PMP links.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
drivers/ata/libata-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index f527c30..0e03644 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5995,7 +5995,7 @@ static void ata_port_detach(struct ata_port *ap)
/* EH is now guaranteed to see UNLOADING - EH context belongs
* to us. Restore SControl and disable all existing devices.
*/
- ata_for_each_link(link, ap, HOST_FIRST) {
+ ata_for_each_link(link, ap, PMP_FIRST) {
sata_scr_write(link, SCR_CONTROL, link->saved_scontrol & 0xff0);
ata_for_each_dev(dev, link, ALL)
ata_dev_disable(dev);
--
1.5.4.5
next prev parent reply other threads:[~2008-11-03 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 11:03 [PATCH #upstream 1/3] libata: beef up iterators Tejun Heo
2008-11-03 11:03 ` Tejun Heo [this message]
2008-11-03 11:04 ` [PATCH #upstream 3/3] libata: perform port detach in EH Tejun Heo
2008-11-11 8:18 ` [PATCH #upstream 1/3] libata: beef up iterators Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490EDA95.6070409@kernel.org \
--to=tj@kernel.org \
--cc=eo@nebensachen.de \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.