From: Andrew Gallatin <gallatin@myri.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [UPDATED PATCH] net: kconfig cleanup
Date: Mon, 03 Nov 2008 08:04:40 -0500 [thread overview]
Message-ID: <490EF6E8.7010609@myri.com> (raw)
In-Reply-To: <20081103043033.13607.2028.stgit@jtkirshe-mobile.jf.intel.com>
Jeff Kirsher wrote:
> The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous,
> so this patch adds a description to the kconfig option.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: Andrew Gallatin <gallatin@myri.com>
> ---
>
> drivers/net/Kconfig | 18 +++++++++++++++---
> 1 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f749b40..11f143f 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2010,9 +2010,13 @@ config IGB_LRO
> If in doubt, say N.
>
> config IGB_DCA
> - bool "Enable DCA"
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on IGB && DCA && !(IGB=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
> source "drivers/net/ixp2000/Kconfig"
>
> @@ -2437,9 +2441,13 @@ config IXGBE
> will be called ixgbe.
>
> config IXGBE_DCA
> - bool
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
> config IXGB
> tristate "Intel(R) PRO/10GbE support"
> @@ -2489,9 +2497,13 @@ config MYRI10GE
> will be called myri10ge.
>
> config MYRI10GE_DCA
> - bool
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
> config NETXEN_NIC
> tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC"
This looks fine to me. Thank you for clarifying.
Drew
next prev parent reply other threads:[~2008-11-03 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 4:30 [UPDATED PATCH] net: kconfig cleanup Jeff Kirsher
2008-11-03 13:04 ` Andrew Gallatin [this message]
2008-11-03 20:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490EF6E8.7010609@myri.com \
--to=gallatin@myri.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.