Re: Compile error of latest hotfix release of btrfs

[Avi Kivity <avi@redhat.com>]

yanhai zhu wrote:
> sorry,
>
> --
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 9b37ce6..04a0e58 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -2539,7 +2539,11 @@ int extent_readpages(struct extent_io_tree *tree,
>                         /* open coding of lru_cache_add, also not exported */
>                         page_cache_get(page);
>                         if (!pagevec_add(&pvec, page))
> +                       #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)
> +                               __pagevec_lru_add_file(&pvec);
> +                       #else
>                                 __pagevec_lru_add(&pvec);
> +                       #endif
>   

Suggest sticking in some compat header:

+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,28)
+#     define  __pagevec_lru_add_file __pagevec_lru_add
+#endif


To reduce impact on code that is intended to go to mainline.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.