From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: Matt Helsley <matthltc@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
Cedric Le Goater <clg@fr.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem
Date: Tue, 04 Nov 2008 15:25:04 +0800 [thread overview]
Message-ID: <490FF8D0.1070607@cn.fujitsu.com> (raw)
In-Reply-To: <6599ad830811032240n640f3fao48f1a9f05892b797@mail.gmail.com>
Paul Menage wrote:
> On Mon, Nov 3, 2008 at 10:12 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> I think another reasonable and easier way is to disable writing freezer.state
>> of top cgroup, so we can skip checks in freezer_fork() for tasks in top cgroup.
>>
>
> Yes, if freezing the root cgroup isn't needed then that is definitely
> simpler - I wasn't sure if Matt wanted to be able to freeze the root
> group with this subsystem.
>
If someone just mounts the freezer subsystem and freeze the root cgroup,
all the tasks will be freezed, and then seems all he can do is reset the
machine (or do a suspend/resume).
That's why I think it's reasonable to disable it.
next prev parent reply other threads:[~2008-11-04 7:28 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 23:53 [PATCH 0/5] Container Freezer v6: Reuse Suspend Freezer Matt Helsley
2008-08-11 23:53 ` [PATCH 1/5] Container Freezer: Add TIF_FREEZE flag to all architectures Matt Helsley
2008-08-11 23:53 ` Matt Helsley
2008-08-11 23:53 ` Matt Helsley
2008-08-11 23:53 ` [PATCH 2/5] Container Freezer: Make refrigerator always available Matt Helsley
2008-08-11 23:53 ` Matt Helsley
2008-08-12 20:49 ` Rafael J. Wysocki
2008-08-12 20:49 ` Rafael J. Wysocki
2008-08-13 1:01 ` [ProbableSpam]Re: " Matt Helsley
2008-08-13 1:01 ` Matt Helsley
2008-08-13 14:31 ` Rafael J. Wysocki
2008-08-13 14:31 ` Rafael J. Wysocki
[not found] ` <1218589300.19008.135.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-13 14:31 ` Rafael J. Wysocki
[not found] ` <200808122249.27553.rjw-KKrjLPT3xs0@public.gmane.org>
2008-08-13 1:01 ` Matt Helsley
[not found] ` <20080811235324.661871296-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-12 20:49 ` Rafael J. Wysocki
2008-08-11 23:53 ` Matt Helsley
2008-08-11 23:53 ` [PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem Matt Helsley
2008-08-11 23:53 ` Matt Helsley
2008-08-12 22:56 ` Andrew Morton
2008-08-13 2:38 ` Matt Helsley
2008-08-13 14:51 ` Rafael J. Wysocki
[not found] ` <1218595088.19008.176.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-08-13 14:51 ` Rafael J. Wysocki
2008-08-13 14:51 ` Rafael J. Wysocki
2008-08-13 2:38 ` Matt Helsley
[not found] ` <20080812155610.f4d40bb1.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-08-13 2:38 ` Matt Helsley
[not found] ` <20080811235325.121356317-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-12 22:56 ` Andrew Morton
2008-08-12 22:56 ` Andrew Morton
2008-11-04 5:43 ` Paul Menage
2008-11-04 6:12 ` Li Zefan
2008-11-04 6:40 ` Paul Menage
2008-11-04 7:25 ` Li Zefan [this message]
2008-11-04 7:35 ` [RFC][PATCH] freezer_cg: disable writing freezer.state of root cgroup Li Zefan
2008-11-04 7:56 ` Paul Menage
2008-11-04 8:01 ` Li Zefan
2008-11-05 10:18 ` Cedric Le Goater
2008-11-05 10:18 ` Cedric Le Goater
2008-11-06 0:48 ` Paul Menage
[not found] ` <4910014F.4000808-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-11-05 10:18 ` Cedric Le Goater
2008-11-06 0:48 ` Paul Menage
2008-11-06 0:48 ` Paul Menage
2008-11-04 6:48 ` [PATCH] freezer_cg: remove task_lock from freezer_fork() Li Zefan
2008-08-11 23:53 ` [PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem Matt Helsley
2008-08-11 23:53 ` [PATCH 4/5] Container Freezer: Skip frozen cgroups during power management resume Matt Helsley
2008-08-12 20:50 ` Rafael J. Wysocki
2008-08-12 20:50 ` Rafael J. Wysocki
[not found] ` <20080811235325.485466148-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-12 20:50 ` Rafael J. Wysocki
2008-08-11 23:53 ` Matt Helsley
2008-08-11 23:53 ` Matt Helsley
2008-08-11 23:53 ` [PATCH 5/5] Container Freezer: Prevent frozen tasks or cgroups from changing Matt Helsley
2008-08-11 23:53 ` Matt Helsley
2008-08-11 23:53 ` Matt Helsley
[not found] ` <20080811235323.872291138-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-08-12 22:44 ` [PATCH 0/5] Container Freezer v6: Reuse Suspend Freezer Andrew Morton
2008-08-12 22:44 ` Andrew Morton
[not found] ` <20080812154429.c5377bd0.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-08-13 3:47 ` [linux-pm] " Vivek Kashyap
2008-08-13 3:47 ` Vivek Kashyap
2008-08-13 3:47 ` [linux-pm] " Vivek Kashyap
2008-08-13 4:08 ` Andrew Morton
2008-08-13 4:08 ` [linux-pm] " Andrew Morton
2008-08-15 21:54 ` Matt Helsley
[not found] ` <20080812210859.ff2fa2f4.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-08-15 21:54 ` [linux-pm] " Matt Helsley
2008-08-15 21:54 ` Matt Helsley
2008-08-13 4:08 ` Andrew Morton
2008-08-12 22:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490FF8D0.1070607@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=clg@fr.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=matthltc@us.ibm.com \
--cc=menage@google.com \
--cc=rjw@sisk.pl \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.