From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] sched: add sanity check in partition_sched_domains()
Date: Tue, 04 Nov 2008 18:06:14 +0800 [thread overview]
Message-ID: <49101E96.2010609@cn.fujitsu.com> (raw)
In-Reply-To: <20081104092848.GM23790@elte.hu>
> a small detail, i changed this:
>
>> + BUG_ON(dattr_new);
>
> to WARN_ON_ONCE().
>
> If there's a rare setup-time memory leak we dont want to crash the box
> via a BUG_ON(), as that only results in unhappy users. We want a
> WARN_ON_ONCE() so that we get nice bugreports and kerneloops.org
> coverage as well instead.
>
> We use BUG_ON() in new code only in the rarest of circumstances: if we
> absolutely want to bring down the box right there - because there's a
> serious risk of data corruption, security breach, etc.
>
I see the point, thx for the explanation. :)
prev parent reply other threads:[~2008-11-04 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 8:20 [PATCH] sched: add sanity check in partition_sched_domains() Li Zefan
2008-11-04 9:28 ` Ingo Molnar
2008-11-04 10:06 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49101E96.2010609@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.